V10: Update dependencies #1782
V10: Update dependencies #1782
Conversation
…htly update rubocop gems
| message = Cucumber::Messages::Envelope.new( | ||
| test_run_started: Cucumber::Messages::TestRunStarted.new( | ||
| timestamp: time_to_timestamp(Time.now) | ||
| timestamp: time_to_timestamp(Time.now), | ||
| id: event.test_cases.first.id |
There was a problem hiding this comment.
The id on a TestRunStarted should be a generated id that represents the entire test run - it doesn't pertain to any particular test case or attempt. The same value should then go on TestRunFinished.testRunStartedId at the end.
… during the test run started event
Change order of broadcast such that test case ready comes after test run started
Rename phase to type for type of hook Add hook type to envelope creation Ensure enum conversion is adherent to message enum validation (Around hook is the outlier here - InstallPlugin can be converted adherently)
|
For anyone monitoring. CCK conformance (To target v17), is about 90% complete now. We are having issues with 1 last CCK spec (retry). Once we have CCK v17 compliance, the remaining items are just refactors and some tidy ups. That then is the last blocker for v10 being released. |
lib/cucumber/runtime.rb
Outdated
| unless configuration.dry_run? | ||
| filters << Filters::BroadcastTestRunStartedEvent.new(@configuration) | ||
| filters << Filters::Quit.new | ||
| filters << Filters::Retry.new(@configuration) | ||
| # need to do this last so it becomes the first test step | ||
| filters << Filters::PrepareWorld.new(self) | ||
| end | ||
|
|
||
| filters << Filters::BroadcastTestCaseReadyEvent.new(@configuration) |
There was a problem hiding this comment.
Note to self (cc/ @davidjgoss )
This is the cause of the retry CCK blowing up
|
Truffleruby issue: oracle/truffleruby#3870 |
| @@ -27,4 +27,15 @@ | |||
|
|
|||
| expect(comparator.errors).to be_empty, "There were comparison errors: #{comparator.errors}" | |||
| end | |||
|
|
|||
| it 'ensures a consistent `testRunStartedId` across the entire test run' do | |||
There was a problem hiding this comment.
@davidjgoss I think this removes the need to sanity check anything. Spoke with Rien on the call about this yesterday. My understanding here is every id should be identical across the suite for this check
| include: | ||
| - os: ubuntu-latest | ||
| ruby: jruby-9.4 | ||
| - os: ubuntu-latest | ||
| ruby: truffleruby-24 |
There was a problem hiding this comment.
| ruby: truffleruby-24 | |
| ruby: truffleruby |
(see other comment)
| @@ -22,7 +22,7 @@ jobs: | |||
| - os: ubuntu-latest | |||
| ruby: jruby-9.4 | |||
| - os: ubuntu-latest | |||
| ruby: truffleruby-head | |||
| ruby: truffleruby-24 | |||
There was a problem hiding this comment.
| ruby: truffleruby-24 | |
| ruby: truffleruby |
I would recommend this, and the same in .github/workflows/release.yaml.
That will only pick truffleruby releases, and avoid using something too old (it's too easy to forget updating this version).
You could also keep using truffleruby-head now that oracle/truffleruby#3870 is fixed and the latest truffleruby-head build includes this.
But maybe you want more stability in cucumber CI and that is fine.
Your bug report was helpful to catch this early though, and switching to only releases means it might be caught later.
There was a problem hiding this comment.
I think given it's fixed we might just undo these changes and go back to head. But I've been working on this PR for an age and want to get it out ASAP.
Description
Update dependencies for the final time - Needed for v10 release
Checklist for completion
9.1or JRuby natural updates)Type of change
Please delete options that are not relevant.
work as expected)
Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses